linux-kernel - Re: [PATCH 0/3] staging: rtl8723bs: remove lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210830081428.GB1416@agape.jhs>
Date:   Mon, 30 Aug 2021 10:14:29 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] staging: rtl8723bs: remove lockdep warning

Hello Hans,

On Mon, Aug 30, 2021 at 09:44:01AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 8/30/21 9:09 AM, Fabio Aiuto wrote:
> > This patchseries removes a lockdep warning that turned out to
> > be a false positive.
> > 
> > All "lockable" queues in the driver are initialized by
> > a single function. This confuses lockdep which puts all
> > locks in the same unexistent class.
> > 
> > Fixed it by doing the initalization of queues in place.
> > 
> > Done a small code cleaning and removed the no more
> > used function.
> > 
> > Tested-on: Lenovo ideapad Miix 300-10IBY
> 
> Thank you so much for fixing this.
> 
> The entire series looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> 
> For the series.

Thank you,

fabio

> 
> Regards,
> 
> Hans
>