linux-kernel - Re: [PATCH 0/3] staging: r8188eu: clean up unnecessary type casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA=Fs0==H6_Jne-hRoQWFedPE02zaoL=Mov0mJam52+YQtEHKQ@mail.gmail.com>
Date:   Mon, 30 Aug 2021 01:16:17 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Martin Kaiser <martin@...ser.cx>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] staging: r8188eu: clean up unnecessary type casts

On Sun, 29 Aug 2021 at 12:26, Michael Straube <straube.linux@...il.com> wrote:
>
> This series removes unnecessary type casts from de/encrypt functions
> in core/rtw_security.c.
>
> Tested with Inter-Tech DMG-02 adapter connected to a CCMP network.
>
> Michael Straube (3):
>   staging: r8188eu: convert type of second parameter of rtw_*_encrypt()
>   staging: r8188eu: convert type of second parameter of rtw_*_decrypt()
>   staging: r8188eu: remove unnecessary type casts
>
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c   |  2 +-
>  drivers/staging/r8188eu/core/rtw_recv.c       |  6 +-
>  drivers/staging/r8188eu/core/rtw_security.c   | 61 +++++++++----------
>  drivers/staging/r8188eu/core/rtw_xmit.c       |  6 +-
>  .../staging/r8188eu/include/rtw_security.h    | 12 ++--
>  5 files changed, 42 insertions(+), 45 deletions(-)
>
> --
> 2.32.0
>

Dear Michael,

Looks good to me, built/run fine again, for whole series:

Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil Potter