linux-kernel - Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210830112342.GF12231@kadam>
Date:   Mon, 30 Aug 2021 14:23:42 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kari Argillander <kari.argillander@...il.com>
Cc:     Saurav Girepunje <saurav.girepunje@...il.com>,
        Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        gregkh@...uxfoundation.org, fabioaiuto83@...il.com,
        straube.linux@...il.com, ross.schm.dev@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        saurav.girepunje@...mail.com
Subject: Re: [PATCH v4] staging: r8188eu: core: remove null check before vfree

On Sun, Aug 29, 2021 at 08:13:51PM +0300, Kari Argillander wrote:
> On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
> > Remove NULL check. NULL check before freeing function is not needed.
> > Correct the indentation.
> > 
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
> > ---
> > 
> > ChangeLog V4:
> > - Add Change log below --- line
> > 
> > ChangeLog V3:
> > - Add change log.
> > 
> > ChangeLog V2:
> > - Correct the indentation.
> 
> You need "---" here also.
> 

No.  It works fine.  I applied it myself with `git am` just to be 100%
sure in case I was missing something.

regards,
dan carpenter