linux-kernel - Re: [PATCH 1/2] staging: r8188eu: remove local variable Indexforchannel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA=Fs0maUfQ9ZybeaifcNHyzzCGPS-UPhPMFY_14v9xZ=to8JA@mail.gmail.com>
Date:   Mon, 30 Aug 2021 01:17:40 +0100
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Martin Kaiser <martin@...ser.cx>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging: r8188eu: remove local variable Indexforchannel

On Sun, 29 Aug 2021 at 18:56, Michael Straube <straube.linux@...il.com> wrote:
>
> The local variable Indexforchannel in function
> odm_TXPowerTrackingCallback_ThermalMeter_8188E() is initilaized to 0
> and never changed. Remove the variable and replace its usage with 0.
>
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>  drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> index 356885e27edd..1b0e1e7307cd 100644
> --- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> @@ -110,7 +110,6 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(
>         bool is2t = false;
>
>         u8 OFDM_min_index = 6, rf; /* OFDM BB Swing should be less than +3.0dB, which is required by Arthur */
> -       u8 Indexforchannel = 0/*GetRightChnlPlaceforIQK(pHalData->CurrentChannel)*/;
>         s8 OFDM_index_mapping[2][index_mapping_NUM_88E] = {
>                 {0, 0, 2, 3, 4, 4,              /* 2.4G, decrease power */
>                 5, 6, 7, 7, 8, 9,
> @@ -280,8 +279,8 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(
>
>                                 /* Adujst OFDM Ant_A according to IQK result */
>                                 ele_D = (OFDMSwingTable[(u8)OFDM_index[0]] & 0xFFC00000) >> 22;
> -                               X = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[Indexforchannel].Value[0][0];
> -                               Y = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[Indexforchannel].Value[0][1];
> +                               X = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[0].Value[0][0];
> +                               Y = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[0].Value[0][1];
>
>                                 /*  Revse TX power table. */
>                                 dm_odm->BbSwingIdxOfdm          = (u8)OFDM_index[0];
> @@ -315,8 +314,8 @@ odm_TXPowerTrackingCallback_ThermalMeter_8188E(
>                                         ele_D = (OFDMSwingTable[(u8)OFDM_index[1]] & 0xFFC00000) >> 22;
>
>                                         /* new element A = element D x X */
> -                                       X = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[Indexforchannel].Value[0][4];
> -                                       Y = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[Indexforchannel].Value[0][5];
> +                                       X = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[0].Value[0][4];
> +                                       Y = dm_odm->RFCalibrateInfo.IQKMatrixRegSetting[0].Value[0][5];
>
>                                         if ((X != 0) && (*dm_odm->pBandType == ODM_BAND_2_4G)) {
>                                                 if ((X & 0x00000200) != 0)      /* consider minus */
> --
> 2.33.0
>

Acked-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil