linux-kernel - Re: [PATCH] mcb: fix error handling in mcb_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2fe69bd-316a-b255-9957-9beab6ed60fe@kernel.org>
Date:   Mon, 30 Aug 2021 18:06:43 +0200
From:   Johannes Thumshirn <jth@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Werner <andreas.werner@....de>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mcb: fix error handling in mcb_alloc_bus()

Am 30.08.21 um 16:08 schrieb Dan Carpenter:
> On Tue, Jun 01, 2021 at 03:23:55PM +0200, Johannes Thumshirn wrote:
>>
>> Am 01.06.21 um 11:18 schrieb Dan Carpenter:
>>> There are two bugs:
>>> 1) If ida_simple_get() fails then this code calls put_device(carrier)
>>>    but we haven't yet called get_device(carrier) and probably that
>>>    leads to a use after free.
>>> 2) After device_initialize() then we need to use put_device() to
>>>    release the bus.  This will free the internal resources tied to the
>>>    device and call mcb_free_bus() which will free the rest.
>>>
>>> Fixes: 5d9e2ab9fea4 ("mcb: Implement bus->dev.release callback")
>>> Fixes: 18d288198099 ("mcb: Correctly initialize the bus's device")
>>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>>>
>> Thanks applied
> This is still not in linux-next.
>
> regards,
> dan carpenter

Hi Dan,

Greg asked me to resend the patch with Cc stable and I totally forgot to
do that, my bad.

I'll do that ASAP once the merge window opens again or earlier if Greg
is OK with it.

Byte,
    Johannes