linux-kernel - Re: [PATCH v2 bpf-next 1/3] perf: enable branch record for software events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YS0eXMd5Y5yV/m1m@hirez.programming.kicks-ass.net>
Date:   Mon, 30 Aug 2021 20:07:24 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Song Liu <songliubraving@...com>
Cc:     "open list:BPF (Safe dynamic programs and tools)" 
        <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        "acme@...nel.org" <acme@...nel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "kjain@...ux.ibm.com" <kjain@...ux.ibm.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next 1/3] perf: enable branch record for software
 events

On Mon, Aug 30, 2021 at 05:41:46PM +0000, Song Liu wrote:
> DECLARE_STATIC_CALL(perf_snapshot_branch_stack,
>                    int (*)(struct perf_branch_snapshot *));

> Something like 
> 
> typedef int (perf_snapshot_branch_stack_t)(struct perf_branch_snapshot *);
> DECLARE_STATIC_CALL(perf_snapshot_branch_stack, perf_snapshot_branch_stack_t);
> 
> seems to work fine. 

Oh urg, indeed. It wants a function type, not a function pointer type.
I've been bitten by that before. Go with the typedef, that's the sanest.