linux-kernel - Re: [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210830112653.450eab49@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 30 Aug 2021 11:26:53 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     zhaoxiao <zhaoxiao@...ontech.com>
Cc:     davem@...emloft.net, mcoquelin.stm32@...il.com,
        peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] stmmac: dwmac-loongson: change the pr_info() to
 dev_err() in loongson_dwmac_probe()

On Mon, 30 Aug 2021 09:24:17 +0800 zhaoxiao wrote:
> @@ -69,6 +68,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>  	if (!plat)
>  		return -ENOMEM;
>  
> +
>  	if (plat->mdio_node) {
>  		dev_err(&pdev->dev, "Found MDIO subnode\n");
>  		mdio = true;
> @@ -111,6 +111,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>  	phy_mode = device_get_phy_mode(&pdev->dev);
>  	if (phy_mode < 0)
>  		dev_err(&pdev->dev, "phy_mode not found\n");
> +	
>  
>  	plat->phy_interface = phy_mode;
>  	plat->interface = PHY_INTERFACE_MODE_GMII;

Please remove these changes from the patch.