| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <YS6kHkeOKCJMOOIf@robh.at.kernel.org>
Date: Tue, 31 Aug 2021 16:50:22 -0500
From: Rob Herring <robh@...nel.org>
To: Nicolas Frattaroli <frattaroli.nicolas@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
linux-rockchip@...ts.infradead.org, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: sound: add rockchip i2s-tdm binding
On Sat, Aug 28, 2021 at 04:02:02PM +0200, Nicolas Frattaroli wrote:
> This adds the YAML bindings for the Rockchip I2S/TDM audio driver.
>
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@...il.com>
> ---
> .../bindings/sound/rockchip,i2s-tdm.yaml | 218 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 219 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
> new file mode 100644
> index 000000000000..ab8731779805
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
> @@ -0,0 +1,218 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/rockchip,i2s-tdm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip I2S/TDM Controller
> +
> +description:
> + The Rockchip I2S/TDM Controller is a Time Division Multiplexed
> + audio interface found in various Rockchip SoCs, allowing up
> + to 8 channels of audio over a serial interface.
> +
> +maintainers:
> + - Nicolas Frattaroli <frattaroli.nicolas@...il.com>
> +
> +properties:
> + compatible:
> + enum:
> + - rockchip,px30-i2s-tdm
> + - rockchip,rk1808-i2s-tdm
> + - rockchip,rk3308-i2s-tdm
> + - rockchip,rk3568-i2s-tdm
> + - rockchip,rv1126-i2s-tdm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + dmas:
> + minItems: 1
> + maxItems: 2
> +
> + dma-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + enum:
> + - rx
> + - tx
> +
> + clocks:
> + minItems: 3
> + items:
> + - description: clock for TX
> + - description: clock for RX
> + - description: AHB clock driving the interface
> + - description:
> + Parent clock for mclk_tx (only required when using mclk-calibrate)
> + - description:
> + Parent clock for mclk_rx (only required when using mclk-calibrate)
> + - description:
> + Clock for sample rates that are an integer multiple of 8000
> + (only required when using mclk-calibrate)
> + - description:
> + Clock for sample rates that are an integer multiple of 11025
> + (only required when using mclk-calibrate)
> +
> + clock-names:
> + minItems: 3
> + items:
> + - const: mclk_tx
> + - const: mclk_rx
> + - const: hclk
> + - const: mclk_tx_src
> + - const: mclk_rx_src
> + - const: mclk_root0
> + - const: mclk_root1
> +
> + rockchip,frame-width:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 64
> + minimum: 32
> + maximum: 512
> + description:
> + Width of a frame, usually slot width multiplied by number of slots.
> + Must be even.
> +
> + resets:
> + items:
> + - description: reset for TX
> + - description: reset for RX
> +
> + reset-names:
> + items:
> + - const: tx-m
> + - const: rx-m
> +
> + rockchip,cru:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The phandle of the cru.
> + Required if neither trcm-sync-tx-only nor trcm-sync-rx-only are specified.
> +
> + rockchip,grf:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The phandle of the syscon node for the GRF register.
> +
> + rockchip,mclk-calibrate:
> + description:
> + Switch between two root clocks depending on the audio sample rate.
> + For integer multiples of 8000 (e.g. 48000 Hz), mclk_root0 is used.
> + For integer multiples of 11025 (e.g. 44100 Hz), mclk_root1 is used.
> + type: boolean
> +
> + rockchip,trcm-sync-tx-only:
> + type: boolean
> + description: Use TX BCLK/LRCK for both TX and RX.
> +
> + rockchip,trcm-sync-rx-only:
> + type: boolean
> + description: Use RX BCLK/LRCK for both TX and RX.
> +
> + "#sound-dai-cells":
> + const: 0
> +
> + rockchip,i2s-rx-route:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + Defines the mapping of I2S RX sdis to I2S data bus lines.
> + By default, they are mapped one-to-one.
> + items:
> + - description: which sdi to connect to data line 0
> + - description: which sdi to connect to data line 1
> + - description: which sdi to connect to data line 2
> + - description: which sdi to connect to data line 3
This would be better expressed as:
maxItems: 4
items:
enum: [ 0, 1, 2, 3 ]
(I'm guessing on the allowed values here)
> +
> + rockchip,i2s-tx-route:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + Defines the mapping of I2S TX sdos to I2S data bus lines.
> + By default, they are mapped one-to-one.
> + items:
> + - description: which sdo to connect to data line 0
> + - description: which sdo to connect to data line 1
> + - description: which sdo to connect to data line 2
> + - description: which sdo to connect to data line 3
Same here.
> +
> + rockchip,tdm-fsync-half-frame:
> + description: Whether to use half frame fsync.
> + type: boolean
> +
> + rockchip,io-multiplex:
> + description:
> + Specify that the GPIO lines on the I2S bus are multiplexed such that
> + the direction (input/output) needs to be dynamically adjusted.
> + type: boolean
> +
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - dmas
> + - dma-names
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> + - rockchip,grf
> + - "#sound-dai-cells"
> +
> +allOf:
> + - if:
> + properties:
> + rockchip,trcm-sync-tx-only: false
> + rockchip,trcm-sync-rx-only: false
> + then:
> + required:
> + - rockchip,cru
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/rk3568-cru.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/pinctrl/rockchip.h>
> +
> + foo {
bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + i2s@...10000 {
> + compatible = "rockchip,rk3568-i2s-tdm";
> + reg = <0x0 0xfe410000 0x0 0x1000>;
> + interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru MCLK_I2S1_8CH_TX>, <&cru MCLK_I2S1_8CH_RX>,
> + <&cru HCLK_I2S1_8CH>;
> + clock-names = "mclk_tx", "mclk_rx", "hclk";
> + dmas = <&dmac1 3>, <&dmac1 2>;
> + dma-names = "rx", "tx";
> + resets = <&cru SRST_M_I2S1_8CH_TX>, <&cru SRST_M_I2S1_8CH_RX>;
> + reset-names = "tx-m", "rx-m";
> + rockchip,trcm-sync-tx-only;
> + rockchip,cru = <&cru>;
> + rockchip,grf = <&grf>;
> + #sound-dai-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 =
> + <&i2s1m0_sclktx
> + &i2s1m0_sclkrx
> + &i2s1m0_lrcktx
> + &i2s1m0_lrckrx
> + &i2s1m0_sdi0
> + &i2s1m0_sdi1
> + &i2s1m0_sdi2
> + &i2s1m0_sdi3
> + &i2s1m0_sdo0
> + &i2s1m0_sdo1
> + &i2s1m0_sdo2
> + &i2s1m0_sdo3>;
> + status = "okay";
Still needs to be dropped.
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5d459d42672c..d2be16a85009 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16053,6 +16053,7 @@ ROCKCHIP I2S TDM DRIVER
> M: Nicolas Frattaroli <frattaroli.nicolas@...il.com>
> L: linux-rockchip@...ts.infradead.org
> S: Maintained
> +F: Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
> F: sound/soc/rockchip/rockchip_i2s_tdm.*
>
> ROCKCHIP ISP V1 DRIVER
> --
> 2.33.0
>
>
Powered by blists - more mailing lists