linux-kernel - Re: [PATCH] mmc: sdhci: Change the code to check auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcdf7aff-0537-357c-ba29-4fb5d1cfa605@intel.com>
Date:   Tue, 31 Aug 2021 10:37:18 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Chanwoo Lee <cw9316.lee@...sung.com>, ulf.hansson@...aro.org,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     grant.jung@...sung.com, jt77.jang@...sung.com,
        dh0421.hwang@...sung.com, sh043.lee@...sung.com
Subject: Re: [PATCH] mmc: sdhci: Change the code to check auto_cmd23

On 25/08/21 12:33 pm, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@...sung.com>
> 
> It is replaced with a function that is already declared.
> //[1/5] mmc: sdhci: Add helpers for the auto-CMD23 flag
> //20200412090349.1607-2-adrian.hunter@...el.com
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@...sung.com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 36f15f81a6af..5782650ddf7d 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -3232,7 +3232,7 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask, u32 *intmask_p)
>  			  -ETIMEDOUT :
>  			  -EILSEQ;
>  
> -		if (mrq->sbc && (host->flags & SDHCI_AUTO_CMD23)) {
> +		if (sdhci_auto_cmd23(host, mrq)) {
>  			mrq->sbc->error = err;
>  			__sdhci_finish_mrq(host, mrq);
>  			return;
>