linux-kernel - Re: [PATCH] ocfs2: avoid getting dlm lock of the target directory multiple times during reflink process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abe27a3a-efde-660c-4d9c-d659eba3eab1@linux.alibaba.com>
Date:   Tue, 31 Aug 2021 15:39:59 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     Gang He <ghe@...e.com>, mark@...heh.com, jlbec@...lplan.org
Cc:     linux-kernel@...r.kernel.org, ocfs2-devel@....oracle.com,
        akpm@...ux-foundation.org
Subject: Re: [PATCH] ocfs2: avoid getting dlm lock of the target directory
 multiple times during reflink process



On 8/31/21 2:25 PM, Gang He wrote:
> Hello Joseph and Wengang,
> 
> When you have time, please help review this patch.
> About the deadlock problem which was caused by ocfs2_downconvert_lock failure, we have the fix patch, it is very key.
> But I feel this patch is still useful as a optimization patch, the user
> case is to reflink the files to the same directory concurrently, our users usually backup the files(via reflink) from the cluster nodes concurrently(via crontab) every day/hour.
> The current design, during the reflink process, the node will acquire/release dlm lock of the target directory multiple times,
> this is very inefficient in concurrently reflink.
> 

Sure, I'll spend some time this week.

Thanks,
Joseph