linux-kernel - Re: [efitools PATCH 1/1] Make.rules: enable building on riscv64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb11e204-a306-8857-08a0-267d28c12ef1@canonical.com>
Date:   Tue, 31 Aug 2021 10:33:20 +0200
From:   Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
To:     James Bottomley <James.Bottomley@...senPartnership.com>
Cc:     Ard Biesheuvel <ardb@...nel.org>, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Heinrich Schuchardt <xypron.glpk@....de>
Subject: Re: [efitools PATCH 1/1] Make.rules: enable building on riscv64



On 4/1/21 6:57 PM, Heinrich Schuchardt wrote:
> We can use just the same flags as for aarch64.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
> RISC-V patches for gnu-efi are not yet accepted in upstream. Cf.
> 
> [Gnu-efi-discuss] [PATCH 1/1] Initial support for RISCV64
> https://sourceforge.net/p/gnu-efi/mailman/gnu-efi-discuss/thread/20210401153553.103286-1-xypron.glpk%40gmx.de/#msg37253360
> [Gnu-efi-discuss] [PATCH 1/1] Undefined Status in LibGetVariableAndSize()
> https://sourceforge.net/p/gnu-efi/mailman/gnu-efi-discuss/thread/20210319162557.334645-1-xypron.glpk%40gmx.de/#msg37243995
> 
> You can use
> https://github.com/xypron/gnu-efi/releases/tag/riscv64-2021-04-01 for
> building sbsigntools and efitools.

Hello James,

I did not see any review from you on this patch yet.
https://lore.kernel.org/linux-efi/?q=Make.rules%3A+enable+building+on+riscv64

gnu-efi 3.0.14 has been released with RISC-V support.

Best regards

Heinrich

> ---
>   Make.rules | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Make.rules b/Make.rules
> index 903a5a4..69bd3bd 100644
> --- a/Make.rules
> +++ b/Make.rules
> @@ -10,6 +10,8 @@ else ifeq ($(ARCH),aarch64)
>   ARCH3264 =
>   else ifeq ($(ARCH),arm)
>   ARCH3264 =
> +else ifeq ($(ARCH),riscv64)
> +ARCH3264 =
>   else
>   $(error unknown architecture $(ARCH))
>   endif
> @@ -56,6 +58,11 @@ ifeq ($(ARCH),aarch64)
>     FORMAT = -O binary
>   endif
> 
> +ifeq ($(ARCH),riscv64)
> +  LDFLAGS += --defsym=EFI_SUBSYSTEM=0x0a
> +  FORMAT = -O binary
> +endif
> +
>   %.efi: %.so
>   	$(OBJCOPY) -j .text -j .sdata -j .data -j .dynamic -j .dynsym \
>   		   -j .rel -j .rela -j .rel.* -j .rela.* -j .rel* -j .rela* \
> --
> 2.30.2
>