linux-kernel - Re: [PATCH v2] gpio: viperboard: remove platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJWpOjsJXSDJ3w64MrKeT3Uh1Jx+C7tP44Dj7uF9tnw-Eg@mail.gmail.com>
Date:   Tue, 31 Aug 2021 11:29:46 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Alexandru Ardelean <aardelean@...iqon.com>
Cc:     linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2] gpio: viperboard: remove platform_set_drvdata() call
 in probe

On Wed, Aug 25, 2021 at 9:02 AM Alexandru Ardelean
<aardelean@...iqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> This change removes it.
> Also removing with this change is some logging about the failure to init
> the gpio chip data. There are other logging methods to view that this
> failed.
>
> Signed-off-by: Alexandru Ardelean <aardelean@...iqon.com>
> ---
>
> Changelog v1 -> v2:
> * remove dev_err() prints
> * [styling] added empty line before first devm_gpiochip_add_data()
>
>  drivers/gpio/gpio-viperboard.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpio/gpio-viperboard.c b/drivers/gpio/gpio-viperboard.c
> index c301c1d56dd2..e55d28a8a66f 100644
> --- a/drivers/gpio/gpio-viperboard.c
> +++ b/drivers/gpio/gpio-viperboard.c
> @@ -404,11 +404,10 @@ static int vprbrd_gpio_probe(struct platform_device *pdev)
>         vb_gpio->gpioa.get = vprbrd_gpioa_get;
>         vb_gpio->gpioa.direction_input = vprbrd_gpioa_direction_input;
>         vb_gpio->gpioa.direction_output = vprbrd_gpioa_direction_output;
> +
>         ret = devm_gpiochip_add_data(&pdev->dev, &vb_gpio->gpioa, vb_gpio);
> -       if (ret < 0) {
> -               dev_err(vb_gpio->gpioa.parent, "could not add gpio a");
> +       if (ret < 0)
>                 return ret;
> -       }
>
>         /* registering gpio b */
>         vb_gpio->gpiob.label = "viperboard gpio b";
> @@ -421,15 +420,8 @@ static int vprbrd_gpio_probe(struct platform_device *pdev)
>         vb_gpio->gpiob.get = vprbrd_gpiob_get;
>         vb_gpio->gpiob.direction_input = vprbrd_gpiob_direction_input;
>         vb_gpio->gpiob.direction_output = vprbrd_gpiob_direction_output;
> -       ret = devm_gpiochip_add_data(&pdev->dev, &vb_gpio->gpiob, vb_gpio);
> -       if (ret < 0) {
> -               dev_err(vb_gpio->gpiob.parent, "could not add gpio b");
> -               return ret;
> -       }
> -
> -       platform_set_drvdata(pdev, vb_gpio);
>
> -       return ret;
> +       return devm_gpiochip_add_data(&pdev->dev, &vb_gpio->gpiob, vb_gpio);
>  }
>
>  static struct platform_driver vprbrd_gpio_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart