[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <163040820836.5377.14060243264259649124.git-patchwork-notify@kernel.org>
Date: Tue, 31 Aug 2021 11:10:08 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jason Wang <wangborong@...rlc.com>
Cc: davem@...emloft.net, ioana.ciornei@....com, kuba@...nel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dpaa2-eth: Replace strlcpy with strscpy
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 30 Aug 2021 21:05:31 +0800 you wrote:
> The strlcpy should not be used because it doesn't limit the source
> length. As linus says, it's a completely useless function if you
> can't implicitly trust the source string - but that is almost always
> why people think they should use it! All in all the BSD function
> will lead some potential bugs.
>
> But the strscpy doesn't require reading memory from the src string
> beyond the specified "count" bytes, and since the return value is
> easier to error-check than strlcpy()'s. In addition, the implementation
> is robust to the string changing out from underneath it, unlike the
> current strlcpy() implementation.
>
> [...]
Here is the summary with links:
- dpaa2-eth: Replace strlcpy with strscpy
https://git.kernel.org/netdev/net-next/c/995786ba0dab
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists