linux-kernel - Re: [PATCH 1/2] Bluetooth: btusb: Support public address configuration for MediaTek Chip.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <51A4788D-DDFD-4700-9D50-84F37ADD4883@holtmann.org>
Date:   Tue, 31 Aug 2021 14:31:05 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     "Mark-YW Chen (陳揚文)" 
        <Mark-YW.Chen@...iatek.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Sean Wang <Sean.Wang@...iatek.com>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "michaelfsun@...gle.com" <michaelfsun@...gle.com>,
        "mcchou@...omium.org" <mcchou@...omium.org>
Subject: Re: [PATCH 1/2] Bluetooth: btusb: Support public address
 configuration for MediaTek Chip.

Hi Mark,

>>> The MediaTek chip support vendor specific HCI command(0xfc1a) to
>>> change the public address. Add hdev->set_bdaddr handler for MediaTek
>>> Chip.
>>> 
>>> Signed-off-by: mark-yw.chen <mark-yw.chen@...iatek.com>
>>> ---
>>> drivers/bluetooth/btusb.c | 18 ++++++++++++++++++
>>> 1 file changed, 18 insertions(+)
>>> 
>>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>>> index 60d2fce59a71..41e7c9f28d82 100644
>>> --- a/drivers/bluetooth/btusb.c
>>> +++ b/drivers/bluetooth/btusb.c
>>> @@ -2200,6 +2200,23 @@ struct btmtk_section_map {
>>> 	};
>>> } __packed;
>>> 
>>> +static int btusb_set_bdaddr_mtk(struct hci_dev *hdev, const bdaddr_t
>>> +*bdaddr) {
>>> +	struct sk_buff *skb;
>>> +	long ret;
>>> +
>>> +	skb = __hci_cmd_sync(hdev, 0xfc1a, sizeof(bdaddr), bdaddr,
>> HCI_INIT_TIMEOUT);
>>> +	if (IS_ERR(skb)) {
>>> +		ret = PTR_ERR(skb);
>>> +		bt_dev_err(hdev, "changing Mediatek device address failed
>> (%ld)",
>>> +			   ret);
>>> +		return ret;
>>> +	}
>>> +	kfree_skb(skb);
>>> +
>>> +	return 0;
>>> +}
>>> +
>> 
>> this is not a permanent change, correct? Meaning a power cycle will bring back
>> the original BD_ADDR?
>> 
> 
> Yes, it's not a permanent change.
> After doing a power cycle or Mediatek specific Bluetooth reset, Mediatek Chips will bring back the original  BD_ADDRESS.

ok, good. Then please re-submit against latest bluetooth-next tree. Unfortunately current patch doesn’t apply anymore.

Regards

Marcel