linux-kernel - Re: [PATCH v3 3/7] sched: make schedstats helpers independent of fair sched class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALOAHbDXu+VQQs-fGutj4MHOD9Z83aoQBuVD-QBaoijp6QZ5Dg@mail.gmail.com>
Date:   Tue, 31 Aug 2021 21:27:31 +0800
From:   Yafang Shao <laoar.shao@...il.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Mel Gorman <mgorman@...e.de>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Benjamin Segall <bsegall@...gle.com>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Alison Chaiken <achaiken@...ora.tech>,
        kbuild test robot <lkp@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rt-users <linux-rt-users@...r.kernel.org>
Subject: Re: [PATCH v3 3/7] sched: make schedstats helpers independent of fair
 sched class

On Tue, Aug 31, 2021 at 7:08 PM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Tue, Aug 24, 2021 at 11:29:42AM +0000, Yafang Shao wrote:
> > diff --git a/kernel/sched/stats.c b/kernel/sched/stats.c
> > index 3f93fc3b5648..b2542f4d3192 100644
> > --- a/kernel/sched/stats.c
> > +++ b/kernel/sched/stats.c
> > @@ -4,6 +4,109 @@
> >   */
> >  #include "sched.h"
> >
> > +void __update_stats_wait_start(struct rq *rq, struct task_struct *p,
> > +                            struct sched_statistics *stats)
> > +{
> > +u64 wait_start, prev_wait_start;
>
> indent fail...
>

Sorry about that.
It is strange that my checkpatch.pl didn't find this issue...

> > +
> > +     wait_start = rq_clock(rq);
> > +     prev_wait_start = schedstat_val(stats->wait_start);
> > +
> > +     if (p && likely(wait_start > prev_wait_start))
> > +             wait_start -= prev_wait_start;
> > +
> > +     __schedstat_set(stats->wait_start, wait_start);
> > +}
>
> > diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h
> > index e6905e369c5d..9ecd81b91f26 100644
> > --- a/kernel/sched/stats.h
> > +++ b/kernel/sched/stats.h
>
> > @@ -40,6 +42,33 @@ rq_sched_info_dequeue(struct rq *rq, unsigned long long delta)
> >  #define   schedstat_val(var)         (var)
> >  #define   schedstat_val_or_zero(var) ((schedstat_enabled()) ? (var) : 0)
> >
> > +void __update_stats_wait_start(struct rq *rq, struct task_struct *p,
> > +                            struct sched_statistics *stats);
> > +
> > +void __update_stats_wait_end(struct rq *rq, struct task_struct *p,
> > +                          struct sched_statistics *stats);
> > +void __update_stats_enqueue_sleeper(struct rq *rq, struct task_struct *p,
> > +                                 struct sched_statistics *stats);
> > +
> > +static inline void
> > +check_schedstat_required(void)
> > +{
> > +     if (schedstat_enabled())
> > +             return;
> > +
> > +     /* Force schedstat enabled if a dependent tracepoint is active */
> > +     if (trace_sched_stat_wait_enabled()    ||
> > +             trace_sched_stat_sleep_enabled()   ||
> > +             trace_sched_stat_iowait_enabled()  ||
> > +             trace_sched_stat_blocked_enabled() ||
> > +             trace_sched_stat_runtime_enabled())  {
> > +             printk_deferred_once("Scheduler tracepoints stat_sleep, stat_iowait, "
> > +                                     "stat_blocked and stat_runtime require the "
> > +                                     "kernel parameter schedstats=enable or "
> > +                                     "kernel.sched_schedstats=1\n");
> > +     }
> > +}
>
> If you're moving this, you might as well reflow it to not have broken
> indentation.

Sure.


-- 
Thanks
Yafang