linux-kernel - Re: [PATCH 3/3 V6] selftest: KVM: Add intra host migration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA03e5Fp2PeY162sL6YVn44an28RBNvbRRF4HLJ_vea9V69Ryg@mail.gmail.com>
Date:   Tue, 31 Aug 2021 08:20:43 -0700
From:   Marc Orr <marcorr@...gle.com>
To:     Peter Gonda <pgonda@...gle.com>
Cc:     kvm list <kvm@...r.kernel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        Brijesh Singh <brijesh.singh@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3 V6] selftest: KVM: Add intra host migration

> > > > +
> > > > +       for (i = 0; i < 1000; ++i) {
> > > > +               j = input->source_fds[i % LOCK_TESTING_THREADS];
> > > > +               cap.args[0] = input->source_fds[j];
> > > > +               /*
> > > > +                * Call IOCTL directly without checking return code. We are
> > > > +                * simply trying to confirm there is no deadlock from userspace
> > > > +                * not check correctness of migration here.
> > > > +                */
> > > > +               ioctl(input->vm->fd, KVM_ENABLE_CAP, &cap);
> > >
> > > Should we use `vm_enable_cap()` here?
> > >
>
> I took all other suggestions but this one I just updated the comment.
> vm_enable_cap TEST_ASSERT()s if the ioctl fails. Since we are just
> randomly iterating through a bunch of ioclts we fail often so this
> would kill the test.

Gah, of course! My bad. Anyway, sounds good and thanks!