linux-kernel - Re: [PATCH V6 4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4ec1824d9bc36499cea0cc2d1f56415@codeaurora.org>
Date:   Tue, 31 Aug 2021 20:57:22 +0530
From:   rajpat@...eaurora.org
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, rnayak@...eaurora.org,
        saiprakash.ranjan@...eaurora.org, msavaliy@....qualcomm.com,
        skakit@...eaurora.org, sboyd@...nel.org
Subject: Re: [PATCH V6 4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT node

On 2021-08-27 02:31, Matthias Kaehlcke wrote:
> On Thu, Aug 26, 2021 at 06:45:28PM +0530, Rajesh Patil wrote:
>> From: Roja Rani Yarubandi <rojay@...eaurora.org>
>> 
>> Update the compatible string as "qcom,geni-uart".
>> Add interconnects and power-domains. Split the pinctrl
>> functions and correct the gpio pins.
> 
> You could say that uart5 was formerly treated as special
> (dedicated debug uart) and that the change removes this
> specialness and makes it look like any other UART.
> 

Okay

>> split the pinctrl functions to match with SoC dt
> 
> The message should say that this is about the 7280-idp
> 
>> Signed-off-by: Roja Rani Yarubandi <rojay@...eaurora.org>
>> Signed-off-by: Rajesh Patil <rajpat@...eaurora.org>
> 
> The change itself looks good to me, the above are only nits to improve
> the commit message, so:
> 
> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>