linux-kernel - Re: [PATCH] fs/ntfs3: Remove fat ioctl's from ntfs3 driver for now

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca096313-ddb6-6897-67a6-3f0d45deefce@paragon-software.com>
Date:   Tue, 31 Aug 2021 19:19:41 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Kari Argillander <kari.argillander@...il.com>,
        <ntfs3@...ts.linux.dev>
CC:     <linux-kernel@...r.kernel.org>,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH] fs/ntfs3: Remove fat ioctl's from ntfs3 driver for now



On 24.08.2021 21:20, Kari Argillander wrote:
> For some reason we have FAT ioctl calls. Even old ntfs driver did not
> use these. We should not use these because it his hard to get things out
> of kernel when they are upstream. That's why we remove these for now.
> 
> More discussion is needed what ioctl should be implemented and what is
> important.
> 
> Signed-off-by: Kari Argillander <kari.argillander@...il.com>
> ---
> Earlier disgussion with Pali can be founded here:
> lore.kernel.org/linux-fsdevel/20210824113304.eabzy7ulbuouzlac@...i/
> ---
>  fs/ntfs3/file.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index 59344985c2e8..819afc4c902b 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -10,7 +10,6 @@
>  #include <linux/compat.h>
>  #include <linux/falloc.h>
>  #include <linux/fiemap.h>
> -#include <linux/msdos_fs.h> /* FAT_IOCTL_XXX */
>  #include <linux/nls.h>
>  
>  #include "debug.h"
> @@ -50,15 +49,8 @@ static long ntfs_ioctl(struct file *filp, u32 cmd, unsigned long arg)
>  {
>  	struct inode *inode = file_inode(filp);
>  	struct ntfs_sb_info *sbi = inode->i_sb->s_fs_info;
> -	u32 __user *user_attr = (u32 __user *)arg;
>  
>  	switch (cmd) {
> -	case FAT_IOCTL_GET_ATTRIBUTES:
> -		return put_user(le32_to_cpu(ntfs_i(inode)->std_fa), user_attr);
> -
> -	case FAT_IOCTL_GET_VOLUME_ID:
> -		return put_user(sbi->volume.ser_num, user_attr);
> -
>  	case FITRIM:
>  		return ntfs_ioctl_fitrim(sbi, arg);
>  	}
> 

Hi, Kari!

Applied, thanks.

Best regards.