linux-kernel - Re: [Outreachy kernel] [PATCH] [Outreachy Kernel] Staging: wlan-ng: cfg80211: Fix Lines should not end with a '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YS6NSLhZKx0mlcYC@casper.infradead.org>
Date:   Tue, 31 Aug 2021 21:12:56 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Tawah Peggy <tawahpeggy98@...il.com>
Cc:     outreachy-kernel@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] [Outreachy Kernel] Staging: wlan-ng:
 cfg80211: Fix Lines should not end with a '('

On Mon, Aug 30, 2021 at 01:41:58PM +0100, Tawah Peggy wrote:
> Thanks for your feedback Mattew,
> please what approach do you suggest I use?

[please don't remove mailing lists; other people may benefit from the
answers to your questions]

There are a number of different approaches you can take to fixing this
kind of warning.

1. Reduce indentation.  This call seems to be indented 3-4 levels,
so maybe it would be good to pull part of this function out into
a helper function.

2. Use a local variable.
			type center_freq = request->channels[i]->center_freq;
			ieee80211_frequency_to_channel(center_freq);

3. Reduce the length of the function name.  ieee80211_frequency_to_channel
is quite a long identifier.  Maybe it would be worth renaming.

4. Introduce a helper function, eg

static inline foo something_to_channel(struct bar *channel)
{
	return ieee80211_frequency_to_channel(channel->center_freq);
}

...

			something_to_channel(request->channels[i]);

There's a judgement call to be made, and without looking at the function
in detail, I don't know which of these methods might be best.

> tawah peggy
> 
> On Tue, Aug 24, 2021 at 10:50 AM Matthew Wilcox <willy@...radead.org> wrote:
> 
> > On Tue, Aug 24, 2021 at 04:15:51AM +0100, Tawah Peggy wrote:
> > > -                     ieee80211_frequency_to_channel(
> > > -                             request->channels[i]->center_freq);
> > > +                     ieee80211_frequency_to_channel
> > > +                             (request->channels[i]->center_freq);
> >
> > This is the wrong way to fix this warning.  Function names should not be
> > divorced from their arguments.
> >