linux-kernel - Re: [PATCH] tools build: Fix feature detect clean for out of source builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YS+NlBGl1xMqHlgC@kernel.org>
Date:   Wed, 1 Sep 2021 11:26:28 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     James Clark <james.clark@....com>, jolsa@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools build: Fix feature detect clean for out of source
 builds

Em Tue, Aug 31, 2021 at 08:46:10PM +0200, Jiri Olsa escreveu:
> On Mon, Aug 16, 2021 at 02:07:05PM +0100, James Clark wrote:
> > Currently the clean target when using O= isn't cleaning the feature
> > detect output. This is because O= and OUTPUT= are set to canonical
> > paths. For example in tools/perf/Makefile:
> > 
> >   FULL_O := $(shell cd $(PWD); readlink -f $(O) || echo $(O))
> > 
> > This means that OUTPUT ends in a / and most usages prepend it to a file
> > without adding an extra /. This line that was changed adds an extra /
> > before the 'feature' folder but not to the end, resulting in a clean
> > command like this:
> > 
> >   rm -f /tmp/build//featuretest-all.bin ...
> > 
> > After the change the clean command looks like this:
> > 
> >   rm -f /tmp/build/feature/test-all.bin ...
> > 
> > Signed-off-by: James Clark <james.clark@....com>
> 
> nice catch!
> 
> Acked-by: Jiri Olsa <jolsa@...hat.com>

Thanks, applied and added:

Fixes: 762323eb39a257c3 ("perf build: Move feature cleanup under tools/build")

- Arnaldo