linux-kernel - Re: [PATCH v3 1/1] ishtp: Add support for Intel ishtp eclite driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e82bbb6-59c1-e713-f153-57ddd1e68163@infradead.org>
Date:   Wed, 1 Sep 2021 12:31:54 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     sumesh.k.naduvalath@...el.com, hdegoede@...hat.com,
        mgross@...ux.intel.com, srinivas.pandruvada@...ux.intel.com
Cc:     srinivas.pandruvada@...el.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org, ganapathi.chinnu@...el.com,
        nachiketa.kumar@...el.com
Subject: Re: [PATCH v3 1/1] ishtp: Add support for Intel ishtp eclite driver

On 9/1/21 5:43 AM, sumesh.k.naduvalath@...el.com wrote:
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index d12db6c316ea..8a0945ed1182 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1176,6 +1176,22 @@ config INTEL_CHTDC_TI_PWRBTN
>   	  To compile this driver as a module, choose M here: the module
>   	  will be called intel_chtdc_ti_pwrbtn.
>   
> +config INTEL_ISHTP_ECLITE
> +	tristate "Intel ISHTP eclite controller"
> +	depends on INTEL_ISH_HID
> +	depends on ACPI
> +	help
> +	  This driver is for accessing the PSE (Programmable Service Engine),
> +	  an Embedded Controller like IP, using ISHTP (Integrated Sensor Hub

Which "IP" is that?  "an Embedded Controller like IP" doesn't make sense IMO.


> +	  Transport Protocol) to get battery, thermal and UCSI (USB Type-C
> +          Connector System Software Interface) related data from the platform.

Indent above line with tab + 2 spaces instead of many spaces.

> +	  Users who don't want to use discrete Embedded Controller on Intel's
> +	  Elkhartlake platform, can leverage this integrated solution of

	Drop this comma       ^

> +	  ECLite which is part of PSE subsystem.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called intel_ishtp_eclite

End the last sentence with a period ('.').


thanks.
-- 
~Randy