linux-kernel - Re: [PATCH v4 1/5] interconnect: qcom: sdm660: Commonize RPM-QoS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f902b08-bdf2-13b5-acbe-215173e7929a@somainline.org>
Date:   Thu, 2 Sep 2021 00:19:08 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Yassine Oudjana <y.oudjana@...tonmail.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     AngeloGioacchino Del Regno <kholk11@...il.com>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shawn Guo <shawn.guo@...aro.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
Subject: Re: [PATCH v4 1/5] interconnect: qcom: sdm660: Commonize RPM-QoS

Il 02/09/21 00:01, Dmitry Baryshkov ha scritto:
> On 01/09/2021 21:48, AngeloGioacchino Del Regno wrote:
>> Il 01/09/21 14:15, Yassine Oudjana ha scritto:
>>> SoCs such as MSM8996 also control bus QoS in a similar fashion to SDM660,
>>> with some paths being controlled by RPM and others directly by the AP.
>>> Move relevant functions and defines to a new object so that they can be used
>>> in multiple drivers.
>>>
>>> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
>>
>> Hey guys!
>>
>> I'm waiting for the interconnect RPM-QoS commonization to be merged as I have fresh
>> interconnect drivers for MSM8998 and MSM8976, ready to send, that are also using
>> the very same QoS mechanism as SDM660.
> 
> We were also looking onto this. I'd propose to merge sdm660 code into main 
> icc-rpm.c instead of splitting it into separate file. We have enabled QoS for 
> apq8096 (msm8916) and msm8939. See 
> https://lore.kernel.org/linux-arm-msm/20210818015732.1717810-1-dmitry.baryshkov@linaro.org/ 
> for the reference. I'm waiting for Shawn to publish v2 of his fix, then I can post 
> v2 of my patchset.
> 

Merging it into icc-rpm would actually make sense, since the QoS mechanism won't
ever be used by the RPM-Hardened icc... so yeah, on that I agree.

Whenever you guys send the new patchsets, if you can please make sure to Cc me
and/or the other SoMainline guys, we will make sure to review and test the sets
as soon as possible, as a way to speed up the merge process, if that helps!

Thank you,
- Angelo

>>
>> Yassine, please check Shawn's recent patches for SDM660 interconnect, which are
>> fixing some bits for the QoS implementation and adding some required clocks to the
>> SDM660 interconnect driver.
>>
>> Adding Shawn to the Ccs as to make him aware of this patch;
>> also adding Marijn and Konrad from SoMainline as probably interested parties.
>>
>> Cheers!
>> - Angelo
> 
>