linux-kernel - Re: [PATCH] media: imx-pxp: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 01 Sep 2021 08:46:38 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: imx-pxp: Make use of the helper function
 devm_platform_ioremap_resource()

On Wed, 2021-09-01 at 13:51 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>  drivers/media/platform/imx-pxp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c
> index 4321edc0c23d..723b096fedd1 100644
> --- a/drivers/media/platform/imx-pxp.c
> +++ b/drivers/media/platform/imx-pxp.c
> @@ -1636,7 +1636,6 @@ static int pxp_soft_reset(struct pxp_dev *dev)
>  static int pxp_probe(struct platform_device *pdev)
>  {
>  	struct pxp_dev *dev;
> -	struct resource *res;
>  	struct video_device *vfd;
>  	int irq;
>  	int ret;
> @@ -1652,8 +1651,7 @@ static int pxp_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dev->mmio = devm_ioremap_resource(&pdev->dev, res);
> +	dev->mmio = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(dev->mmio))
>  		return PTR_ERR(dev->mmio);

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp