linux-kernel - Re: [PATCH] x86: make setup.c build again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YS8stOCBCdfZ+J0Y@zn.tnic>
Date:   Wed, 1 Sep 2021 09:33:08 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Christoph Hellwig <hch@....de>
Cc:     torvalds@...ux-foundation.org, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: make setup.c build again

On Wed, Sep 01, 2021 at 09:12:32AM +0200, Christoph Hellwig wrote:
> Add a <linux/acpi.h> include to setup.c to ensure it compiles without
> any config-dependent implicit includes of that header.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  arch/x86/kernel/setup.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 63b20536c8d23..6edec9a28293e 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -22,6 +22,7 @@
>  #include <linux/usb/xhci-dbgp.h>
>  #include <linux/static_call.h>
>  #include <linux/swiotlb.h>
> +#include <linux/acpi.h>
>  
>  #include <uapi/linux/mount.h>
>  
> -- 

There's an identical fix

https://lkml.kernel.org/r/20210901021510.1561219-1-nathan@kernel.org

which explains why it happens but I'm fine with whichever one Linus
picks up.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette