linux-kernel - Re: [PATCH] media: rcar_fdp1: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <797f3440-1f3e-d68b-0a20-e190dc36ed5d@ideasonboard.com>
Date:   Wed, 1 Sep 2021 09:16:16 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: rcar_fdp1: Make use of the helper function
 devm_platform_ioremap_resource()

On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>  drivers/media/platform/rcar_fdp1.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index 89aac60066d9..19de3c19bcca 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -2256,7 +2256,6 @@ static int fdp1_probe(struct platform_device *pdev)
>  	struct fdp1_dev *fdp1;
>  	struct video_device *vfd;
>  	struct device_node *fcp_node;
> -	struct resource *res;
>  	struct clk *clk;
>  	unsigned int i;
>  
> @@ -2283,8 +2282,7 @@ static int fdp1_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, fdp1);
>  
>  	/* Memory-mapped registers */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	fdp1->regs = devm_ioremap_resource(&pdev->dev, res);
> +	fdp1->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(fdp1->regs))
>  		return PTR_ERR(fdp1->regs);
>  
>