linux-kernel - Re: [PATCH v2 5.10.x] mtd: spinand: Fix incorrect parameters for on-die ECC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YS83NzasS7jExTya@kroah.com>
Date:   Wed, 1 Sep 2021 10:17:59 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Frieder Schrempf <frieder@...s.de>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Frieder Schrempf <frieder.schrempf@...tron.de>,
        stable@...r.kernel.org,
        voice INTER connect GmbH <developer@...ceinterconnect.de>,
        Alexander Lobakin <alobakin@...me>,
        Felix Fietkau <nbd@....name>, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org, Richard Weinberger <richard@....at>,
        YouChing Lin <ycllin@...c.com.tw>
Subject: Re: [PATCH v2 5.10.x] mtd: spinand: Fix incorrect parameters for
 on-die ECC

On Mon, Aug 30, 2021 at 03:02:10PM +0200, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
> 
> The new generic NAND ECC framework stores the configuration and
> requirements in separate places since commit 93ef92f6f422 ("mtd: nand: Use
> the new generic ECC object"). In 5.10.x The SPI NAND layer still uses only
> the requirements to track the ECC properties. This mismatch leads to
> values of zero being used for ECC strength and step_size in the SPI NAND
> layer wherever nanddev_get_ecc_conf() is used and therefore breaks the SPI
> NAND on-die ECC support in 5.10.x.
> 
> By using nanddev_get_ecc_requirements() instead of nanddev_get_ecc_conf()
> for SPI NAND, we make sure that the correct parameters for the detected
> chip are used. In later versions (5.11.x) this is fixed anyway with the
> implementation of the SPI NAND on-die ECC engine.
> 
> Cc: stable@...r.kernel.org # 5.10.x
> Reported-by: voice INTER connect GmbH <developer@...ceinterconnect.de>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
> Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>
> ---
> Changes in v2:
>   * Fix checkpatch error/warnings for commit message style
>   * Add Miquel's A-b tag

Now queued up, thanks.

greg k-h