[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c519edd0-f263-0df0-40a3-8ba342c0a0fa@tessares.net>
Date: Wed, 1 Sep 2021 10:27:53 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: Wan Jiabing <wanjiabing@...o.com>,
Mat Martineau <mathew.j.martineau@...ux.intel.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc: kael_w@...h.net
Subject: Re: [PATCH] [v3] mptcp: Fix duplicated argument in protocol.h
Hi Wan,
On 01/09/2021 05:19, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> ./net/mptcp/protocol.h:36:50-73: duplicated argument to & or |
>
> The OPTION_MPTCP_MPJ_SYNACK here is duplicate.
> Here should be OPTION_MPTCP_MPJ_ACK.
>
> Fixes: 74c7dfbee3e18 ("mptcp: consolidate in_opt sub-options fields in a bitmask")
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
Thank you for the patch!
It looks good to me too and MPTCP selftests are still happy with this patch.
Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>
Just one thing: please next time mention for which "net" tree this patch
is for. That's why you got one warning on Patchwork [1]. See [2] for
more details.
Here this patch is for -net: [PATCH net].
[1]
https://patchwork.kernel.org/project/netdevbpf/patch/20210901031932.7734-1-wanjiabing@vivo.com/
[2] https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Powered by blists - more mailing lists