linux-kernel - Re: [PATCH] media: sti/c8sectpfe: Make use of the helper function devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Sep 2021 16:41:03 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     Hans Verkuil <hverkuil@...all.nl>
CC:     Patrice Chotard <patrice.chotard@...s.st.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: sti/c8sectpfe: Make use of the helper function
 devm_platform_ioremap_resource_byname()

On 01 Sep 21 10:20:26, Hans Verkuil wrote:
> On 01/09/2021 07:56, Cai Huoqing wrote:
> > Use the devm_platform_ioremap_resource_byname() helper instead of
> > calling platform_get_resource_byname() and devm_ioremap_resource()
> > separately
> > 
> > Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> > ---
> >  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> > index 02dc78bd7fab..9f05984f711a 100644
> > --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> > +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> > @@ -665,7 +665,6 @@ static int c8sectpfe_probe(struct platform_device *pdev)
> >  	struct device *dev = &pdev->dev;
> >  	struct device_node *child, *np = dev->of_node;
> >  	struct c8sectpfei *fei;
> > -	struct resource *res;
> >  	int ret, index = 0;
> >  	struct channel_info *tsin;
> >  
> > @@ -676,14 +675,11 @@ static int c8sectpfe_probe(struct platform_device *pdev)
> >  
> >  	fei->dev = dev;
> >  
> > -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "c8sectpfe");
> > -	fei->io = devm_ioremap_resource(dev, res);
> > +	fei->io = devm_platform_ioremap_resource_byname(pdev, "c8sectpfe");
> >  	if (IS_ERR(fei->io))
> >  		return PTR_ERR(fei->io);
> >  
> > -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> > -					"c8sectpfe-ram");
> > -	fei->sram = devm_ioremap_resource(dev, res);
> > +	fei->sram = devm_platform_ioremap_resource_byname(pdev, "c8sectpfe-ram");
> >  	if (IS_ERR(fei->sram))
> >  		return PTR_ERR(fei->sram);
> >  
> > 
> 
> Compile error:
> 
> drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c: In function ‘c8sectpfe_probe’:
> drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:686:33: error: ‘res’ undeclared (first use in this function); did you mean ‘ret’?
>   686 |  fei->sram_size = resource_size(res);
>       |                                 ^~~
>       |                                 ret
> drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:686:33: note: each undeclared identifier is reported only once for each function it appears in
> 
> Regards,
> 
> 	Hans
I'm very sorry for it, please forget this patch-sti/c8sectpfe.

I have deleted the "struct resource *res;", if 'res' is used
anywhere, compiler will complain,then I should fix it.
But, in this case, I miss sti/c8sectpfe

Cai