linux-kernel - Re: [PATCH v2 1/2] mm: introduce pmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd4e882a-ecbb-6688-1288-112312e9251c@bytedance.com>
Date:   Wed, 1 Sep 2021 18:15:42 +0800
From:   Qi Zheng <zhengqi.arch@...edance.com>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     akpm@...ux-foundation.org, tglx@...utronix.de, hannes@...xchg.org,
        mhocko@...nel.org, vdavydov.dev@...il.com,
        kirill.shutemov@...ux.intel.com, mika.penttila@...tfour.com,
        david@...hat.com, vbabka@...e.cz, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        songmuchun@...edance.com
Subject: Re: [PATCH v2 1/2] mm: introduce pmd_install() helper



On 2021/9/1 AM7:23, Kirill A. Shutemov wrote:
> On Tue, Aug 31, 2021 at 09:21:10PM +0800, Qi Zheng wrote:
>> Currently we have three times the same few lines repeated in the
>> code. Deduplicate them by newly introduced pmd_install() helper.
>>
>> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
>> Reviewed-by: David Hildenbrand <david@...hat.com>
>> Reviewed-by: Muchun Song <songmuchun@...edance.com>
>> ---
>>   include/linux/mm.h |  1 +
>>   mm/filemap.c       | 11 ++---------
>>   mm/memory.c        | 34 ++++++++++++++++------------------
>>   3 files changed, 19 insertions(+), 27 deletions(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index a3cc83d64564..0af420a7e382 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -2463,6 +2463,7 @@ static inline spinlock_t *pud_lock(struct mm_struct *mm, pud_t *pud)
>>   	return ptl;
>>   }
>>   
>> +extern void pmd_install(struct mm_struct *mm, pmd_t *pmd, pgtable_t *pte);
>>   extern void __init pagecache_init(void);
>>   extern void __init free_area_init_memoryless_node(int nid);
>>   extern void free_initmem(void);
> 
> mm/internal.h would be a better fit for the declaration.

OK, I will update it in the next version.

> 
> Otherwise:
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> 

Thanks,
Qi