linux-kernel - Re: [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9304b83-faeb-248e-ac7e-942a53054a1a@ideasonboard.com>
Date:   Wed, 1 Sep 2021 12:05:49 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Jacopo Mondi <jacopo@...ndi.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: renesas-ceu: Make use of the helper function
 devm_platform_ioremap_resource()

On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> ---
>  drivers/media/platform/renesas-ceu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
> index 9376eb363748..2e8dbacc414e 100644
> --- a/drivers/media/platform/renesas-ceu.c
> +++ b/drivers/media/platform/renesas-ceu.c
> @@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev)
>  	struct device *dev = &pdev->dev;
>  	const struct ceu_data *ceu_data;
>  	struct ceu_device *ceudev;
> -	struct resource *res;
>  	unsigned int irq;
>  	int num_subdevs;
>  	int ret;
> @@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev)
>  	spin_lock_init(&ceudev->lock);
>  	mutex_init(&ceudev->mlock);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ceudev->base = devm_ioremap_resource(dev, res);
> +	ceudev->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(ceudev->base)) {
>  		ret = PTR_ERR(ceudev->base);
>  		goto error_free_ceudev;
>