linux-kernel - RE: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSAPR01MB2737C7CCB159F768EDA12ACDC2CD9@OSAPR01MB2737.jpnprd01.prod.outlook.com>
Date:   Wed, 1 Sep 2021 12:22:40 +0000
From:   Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To:     Cai Huoqing <caihuoqing@...du.com>
CC:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4] media: rcar_drif: Make use of the helper function
 devm_platform_get_and_ioremap_resource()

> From: Cai Huoqing <caihuoqing@...du.com>
> Sent: 01 September 2021 12:45
> To: caihuoqing@...du.com
> Cc: Fabrizio Castro <fabrizio.castro.jz@...esas.com>; Mauro Carvalho
> Chehab <mchehab@...nel.org>; linux-media@...r.kernel.org; linux-renesas-
> soc@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH v4] media: rcar_drif: Make use of the helper function
> devm_platform_get_and_ioremap_resource()
> 
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Acked-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>

> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
> 
>  drivers/media/platform/rcar_drif.c | 3 +--
>  1 file changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar_drif.c
> b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device
> *pdev)
>  	}
> 
>  	/* Register map */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ch->base = devm_ioremap_resource(&pdev->dev, res);
> +	ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(ch->base))
>  		return PTR_ERR(ch->base);
> 
> --
> 2.25.1