linux-kernel - Re: [PATCH] mptcp: Fix duplicated argument in protocol.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+WQbwvjzadxGi2yCs+PRdJpwYnj64jkXdgiYset8oX0PZX6xw@mail.gmail.com>
Date:   Wed, 1 Sep 2021 10:56:22 +0800
From:   Geliang Tang <geliangtang@...il.com>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        MPTCP Upstream <mptcp@...ts.linux.dev>,
        "To: Phillip Lougher <phillip@...ashfs.org.uk>, Andrew Morton
        <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Coly Li
        <colyli@...e.de>, linux-fsdevel@...r.kernel.org," 
        <linux-kernel@...r.kernel.org>, kael_w@...h.net
Subject: Re: [PATCH] mptcp: Fix duplicated argument in protocol.h

Hi Jiabing,

Wan Jiabing <wanjiabing@...o.com> 于2021年9月1日周三 上午10:40写道：
>
> ./net/mptcp/protocol.h:36:50-73: duplicated argument to & or |
>
> The OPTION_MPTCP_MPJ_SYNACK here is duplicate.
> Here should be OPTION_MPTCP_MPJ_ACK.
>

Good catch!

Acked-by: Geliang Tang <geliangtang@...il.com>

Please add a Fixes-tag here in v2 like this:

Fixes: 74c7dfbee3e18 ("mptcp: consolidate in_opt sub-options fields in
a bitmask")

Thanks,
-Geliang

> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  net/mptcp/protocol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> index d7aba1c4dc48..64c9a30e0871 100644
> --- a/net/mptcp/protocol.h
> +++ b/net/mptcp/protocol.h
> @@ -34,7 +34,7 @@
>  #define OPTIONS_MPTCP_MPC      (OPTION_MPTCP_MPC_SYN | OPTION_MPTCP_MPC_SYNACK | \
>                                  OPTION_MPTCP_MPC_ACK)
>  #define OPTIONS_MPTCP_MPJ      (OPTION_MPTCP_MPJ_SYN | OPTION_MPTCP_MPJ_SYNACK | \
> -                                OPTION_MPTCP_MPJ_SYNACK)
> +                                OPTION_MPTCP_MPJ_ACK)
>
>  /* MPTCP option subtypes */
>  #define MPTCPOPT_MP_CAPABLE    0
> --
> 2.25.1
>
>