linux-kernel - Re: [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <535478691c3a9ed31b508f59dc897be57c4213c0.camel@mediatek.com>
Date:   Wed, 1 Sep 2021 11:48:27 +0800
From:   Trevor Wu <trevor.wu@...iatek.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: mediatek: SND_SOC_MT8195 should depend on
 ARCH_MEDIATEK

On Tue, 2021-08-31 at 15:18 +0200, Geert Uytterhoeven wrote:
> The Mediatek MT8195 sound hardware is only present on Mediatek MT8195
> SoCs.  Hence add a dependency on ARCH_MEDIATEK, to prevent asking the
> user about this driver when configuring a kernel without Mediatek SoC
> support.
> 
> Fixes: 6746cc858259985a ("ASoC: mediatek: mt8195: add platform
> driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  sound/soc/mediatek/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index cf567a89f421b4c0..c8c815f599da90bf 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -187,6 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
>  
>  config SND_SOC_MT8195
>  	tristate "ASoC support for Mediatek MT8195 chip"
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	select SND_SOC_MEDIATEK
>  	help
>  	  This adds ASoC platform driver support for Mediatek MT8195
> chip

Hi Geert,

Thanks for your patch first.
I really missed the dependency declaration.
But we only test "depends on ARCH_MEDIATEK" internally, maybe removing
"COMPILE_TEST" like other MTK series is better for the maintenance in
the future.

Thanks,
Trevor