linux-kernel - Re: libperf: lack of interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Sep 2021 10:36:40 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Nakamura Shun <nakamura.shun@...itsu.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: libperf: lack of interface

Em Wed, Sep 01, 2021 at 09:45:10AM +0000, nakamura.shun@...itsu.com escreveu:
> Hello.
> 
> I'm trying to change rdpmc test in perf_event_tests[1] to use libperf, but libperf doesn't have enough interfaces.
> Does anyone plan to implement any of these libperf features?
> 
> - Interfaces that can run ioctl (PERF_EVENT_IOC_RESET) from userland
> - Interfaces that can run fcntl (SIGIO) from userland
> 
> [1] https://github.com/deater/perf_event_tests/tree/master/tests/rdpmc

So, while in this specific case you should probably follow PeterZ's
advice, feel free to submit patches moving stuff that is in
tools/perf/util/ to tools/lib/perf/ (libperf) when you have a reasonable
use case, such as Vince's test suite.

We can then discuss if any adjustment is needed, but doing it this
piecemeal way, with justification, should be a good way to enrich
libperf with things that are in quiescent state in tools/perf/util/ and
that have external users.

Thanks,

- Arnaldo