linux-kernel - Re: [PATCH 1/1] debugfs: use IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f34d9a7-d5cb-5b41-7813-11d75eb25f0d@amd.com>
Date:   Thu, 2 Sep 2021 12:31:59 +0200
From:   Christian König <christian.koenig@....com>
To:     Nirmoy Das <nirmoy.das@....com>, rafael@...nel.org
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/1] debugfs: use IS_ERR to check for error



Am 02.09.21 um 12:29 schrieb Nirmoy Das:
> debugfs_create_file() returns encoded error so
> use IS_ERR for checking return value.
>
> References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
> Signed-off-by: Nirmoy Das <nirmoy.das@....com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   fs/debugfs/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 8129a430d789..2f117c57160d 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
>   {
>   	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
>   
> -	if (de)
> +	if (!IS_ERR(de))
>   		d_inode(de)->i_size = file_size;
>   }
>   EXPORT_SYMBOL_GPL(debugfs_create_file_size);