linux-kernel - Re: [PATCH] media: rcar_jpu: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f55b3276-a628-804f-b686-64dd0afcfab4@ideasonboard.com>
Date:   Thu, 2 Sep 2021 11:54:22 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Mikhail Ulyanov <mikhail.ulyanov@...entembedded.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] media: rcar_jpu: Make use of the helper function
 devm_platform_ioremap_resource()

+Cc linux-renesas-soc

On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>


> ---
>  drivers/media/platform/rcar_jpu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c
> index f57158bf2b11..56bb464629ed 100644
> --- a/drivers/media/platform/rcar_jpu.c
> +++ b/drivers/media/platform/rcar_jpu.c
> @@ -1590,7 +1590,6 @@ MODULE_DEVICE_TABLE(of, jpu_dt_ids);
>  static int jpu_probe(struct platform_device *pdev)
>  {
>  	struct jpu *jpu;
> -	struct resource *res;
>  	int ret;
>  	unsigned int i;
>  
> @@ -1603,8 +1602,7 @@ static int jpu_probe(struct platform_device *pdev)
>  	jpu->dev = &pdev->dev;
>  
>  	/* memory-mapped registers */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	jpu->regs = devm_ioremap_resource(&pdev->dev, res);
> +	jpu->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(jpu->regs))
>  		return PTR_ERR(jpu->regs);
>  
>