linux-kernel - Re: [PATCH v2] perf build: Report failure for testing feature libopencsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 02 Sep 2021 10:00:03 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Leo Yan <leo.yan@...aro.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     James Clark <james.clark@....com>, mathieu.poirier@...aro.org,
        coresight@...ts.linaro.org, linux-perf-users@...r.kernel.org,
        mike.leach@...aro.org, suzuki.poulose@....com,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perf build: Report failure for testing feature libopencsd



On September 2, 2021 9:45:29 AM GMT-03:00, Leo Yan <leo.yan@...aro.org> wrote:
>On Thu, Sep 02, 2021 at 09:22:21AM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Thu, Sep 02, 2021 at 04:18:00PM +0800, Leo Yan escreveu:
>> > When build perf tool with passing option 'CORESIGHT=1' explicitly, if
>> > the feature test fails for library libopencsd, the build doesn't
>> > complain the feature failure and continue to build the tool with
>> > disabling the CoreSight feature insteadly.
>> > 
>> > This patch changes the building behaviour, when build perf tool with the
>> > option 'CORESIGHT=1' and detect the failure for testing feature
>> > libopencsd, the build process will be aborted and it shows the complaint
>> > info.
>> 
>> Thanks, added some committer notes to show that it now works:
>> 
>> commit 8fb36b1f54873870262810d3db10526559e1d6c2
>> Author: Leo Yan <leo.yan@...aro.org>
>> Date:   Thu Sep 2 16:18:00 2021 +0800
>> 
>>     perf build: Report failure for testing feature libopencsd
>>     
>>     When build perf tool with passing option 'CORESIGHT=1' explicitly, if
>>     the feature test fails for library libopencsd, the build doesn't
>>     complain the feature failure and continue to build the tool with
>>     disabling the CoreSight feature insteadly.
>>     
>>     This patch changes the building behaviour, when build perf tool with the
>>     option 'CORESIGHT=1' and detect the failure for testing feature
>>     libopencsd, the build process will be aborted and it shows the complaint
>>     info.
>>     
>>     Committer testing:
>>     
>>     First make sure there is no opencsd library installed:
>>     
>>       $ rpm -qa | grep -i csd
>>       $ sudo rm -rf `find /usr/local -name "*csd*"`
>>       $ find /usr/local -name "*csd*"
>>       $
>>     
>>     Then cleanup the perf build output directory:
>>     
>>       $ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ;
>>       $
>>     
>>     And try to build explicitely asking for coresight:
>>     
>>       $ make O=/tmp/build/perf CORESIGHT=1 O=/tmp/build/perf -C tools/perf install-bin
>
>The build command contains duplicate 'O=/tmp/build/perf'.

Oops, I'll fix it, thanks.

- Arnaldo