linux-kernel - Re: [PATCH 5.10 047/103] net: stmmac: add mutex lock to protect est parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YTDW/KTUpKz6C771@sashalap>
Date:   Thu, 2 Sep 2021 09:51:56 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 5.10 047/103] net: stmmac: add mutex lock to protect est
 parameters

On Wed, Sep 01, 2021 at 10:09:53PM +0200, Pavel Machek wrote:
>Hi!
>
>> [ Upstream commit b2aae654a4794ef898ad33a179f341eb610f6b85 ]
>>
>> Add a mutex lock to protect est structure parameters so that the
>> EST parameters can be updated by other threads.
>
>Mainline version of the patch is okay, but I believe we need one more
>mutex_unlock in 5.10.

I think you're right. Looks like it's because we don't have 5a5586112b92
("net: stmmac: support FPE link partner hand-shaking procedure") in 5.10
(and I don't think it makes sense to backport it either).

I've squashed your patch into the backport, thanks!

-- 
Thanks,
Sasha