linux-kernel - Re: [PATCH] fs/ntfs3: Change how module init/info messages are displayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c05acf1-b6eb-09b0-e4ea-e9d3c6343545@paragon-software.com>
Date:   Thu, 2 Sep 2021 19:37:25 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Kari Argillander <kari.argillander@...il.com>,
        <ntfs3@...ts.linux.dev>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/ntfs3: Change how module init/info messages are
 displayed



On 29.08.2021 17:42, Kari Argillander wrote:
> Usually in file system init() messages are only displayed in info level.
> Change level from notice to info, but keep CONFIG_NTFS3_64BIT_CLUSTER in
> notice level. Also this need even more attention so let's put big
> warning here so that nobody will not try accidentally use it.
> 
> There is also no good reason to display internal stuff like binary tree
> search. This is always on option which can only disabled for debugging
> purposes by developer. Also this message does not even check if
> developer has disabled it or not so it is useless info.
> 
> Signed-off-by: Kari Argillander <kari.argillander@...il.com>
> ---
>  fs/ntfs3/super.c | 27 ++++++++-------------------
>  1 file changed, 8 insertions(+), 19 deletions(-)
> 
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 17ee715ab539..7895039cf673 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -1430,21 +1430,14 @@ static int __init init_ntfs_fs(void)
>  {
>  	int err;
>  
> -	pr_notice("ntfs3: Index binary search\n");
> -	pr_notice("ntfs3: Hot fix free clusters\n");
> -	pr_notice("ntfs3: Max link count %u\n", NTFS_LINK_MAX);
> +	pr_info("ntfs3: Max link count %u\n", NTFS_LINK_MAX);
>  
> -#ifdef CONFIG_NTFS3_FS_POSIX_ACL
> -	pr_notice("ntfs3: Enabled Linux POSIX ACLs support\n");
> -#endif
> -#ifdef CONFIG_NTFS3_64BIT_CLUSTER
> -	pr_notice("ntfs3: Activated 64 bits per cluster\n");
> -#else
> -	pr_notice("ntfs3: Activated 32 bits per cluster\n");
> -#endif
> -#ifdef CONFIG_NTFS3_LZX_XPRESS
> -	pr_notice("ntfs3: Read-only lzx/xpress compression included\n");
> -#endif
> +	if (IS_ENABLED(CONFIG_NTFS3_FS_POSIX_ACL))
> +		pr_info("ntfs3: Enabled Linux POSIX ACLs support\n");
> +	if (IS_ENABLED(CONFIG_NTFS3_64BIT_CLUSTER))
> +		pr_notice("ntfs3: Warning: Activated 64 bits per cluster. Windows does not support this\n");
> +	if (IS_ENABLED(CONFIG_NTFS3_LZX_XPRESS))
> +		pr_info("ntfs3: Read-only LZX/Xpress compression included\n");
>  
>  	err = ntfs3_init_bitmap();
>  	if (err)
> @@ -1484,15 +1477,11 @@ static void __exit exit_ntfs_fs(void)
>  
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("ntfs3 read/write filesystem");
> -MODULE_INFO(behaviour, "Index binary search");
> -MODULE_INFO(behaviour, "Hot fix free clusters");
>  #ifdef CONFIG_NTFS3_FS_POSIX_ACL
>  MODULE_INFO(behaviour, "Enabled Linux POSIX ACLs support");
>  #endif
>  #ifdef CONFIG_NTFS3_64BIT_CLUSTER
> -MODULE_INFO(cluster, "Activated 64 bits per cluster");
> -#else
> -MODULE_INFO(cluster, "Activated 32 bits per cluster");
> +MODULE_INFO(cluster, "Warning: Activated 64 bits per cluster. Windows does not support this");
>  #endif
>  #ifdef CONFIG_NTFS3_LZX_XPRESS
>  MODULE_INFO(compression, "Read-only lzx/xpress compression included");
> 

Applied, thanks!