Message-ID: <5428d654-a24d-7d8b-489c-b666d72043c1@amd.com>
Date:   Thu, 2 Sep 2021 14:58:11 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     brijesh.singh@....com, x86@...nel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        linux-efi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-coco@...ts.linux.dev, linux-mm@...ck.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Joerg Roedel <jroedel@...e.de>,
        Tom Lendacky <thomas.lendacky@....com>,
        "H. Peter Anvin" <hpa@...or.com>, Ard Biesheuvel <ardb@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Sergio Lopez <slp@...hat.com>, Peter Gonda <pgonda@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        David Rientjes <rientjes@...gle.com>,
        Dov Murik <dovmurik@...ux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@....com>,
        Michael Roth <michael.roth@....com>,
        Vlastimil Babka <vbabka@...e.cz>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Andi Kleen <ak@...ux.intel.com>, tony.luck@...el.com,
        marcorr@...gle.com, sathyanarayanan.kuppuswamy@...ux.intel.com
Subject: Re: [PATCH Part1 v5 35/38] x86/sev: Register SNP guest request
 platform device



On 9/2/21 11:40 AM, Borislav Petkov wrote:
> On Fri, Aug 20, 2021 at 10:19:30AM -0500, Brijesh Singh wrote:
>> Version 2 of GHCB specification provides NAEs that can be used by the SNP
> 
> Resolve the "NAE" abbreviation here so that it is clear what this means.
> 
Noted.

>> guest to communicate with the PSP without risk from a malicious hypervisor
>> who wishes to read, alter, drop or replay the messages sent.
> 
> This here says "malicious hypervisor" from which we protect from...
> 
>> In order to communicate with the PSP, the guest need to locate the secrets
>> page inserted by the hypervisor during the SEV-SNP guest launch. The
> 
> ... but this here says the secrets page is inserted by the same
> hypervisor from which we're actually protecting.
> 

The content of the secret page is populated by the PSP. Hypervisor 
cannot alter the contents; all it can do tell the guest where the 
secrets page is present in the memory. The guest will read the secrets 
page to get the VM communication key and use that key to encrypt the 
message send between the PSP and guest.


> You wanna rephrase that to explain what exactly happens so that it
> doesn't sound like we're really trusting the HV with the secrets page.
> 

Sure, I will expand it a bit more.

>> secrets page contains the communication keys used to send and receive the
>> encrypted messages between the guest and the PSP. The secrets page location
>> is passed through the setup_data.
>>
>> Create a platform device that the SNP guest driver can bind to get the
>> platform resources such as encryption key and message id to use to
>> communicate with the PSP. The SNP guest driver can provide userspace
>> interface to get the attestation report, key derivation, extended
>> attestation report etc.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@....com>
>> ---
>>   arch/x86/kernel/sev.c     | 68 +++++++++++++++++++++++++++++++++++++++
>>   include/linux/sev-guest.h |  5 +++
>>   2 files changed, 73 insertions(+)
> 
> ...
> 
>> +static u64 find_secrets_paddr(void)
>> +{
>> +	u64 pa_data = boot_params.cc_blob_address;
>> +	struct cc_blob_sev_info info;
>> +	void *map;
>> +
>> +	/*
>> +	 * The CC blob contains the address of the secrets page, check if the
>> +	 * blob is present.
>> +	 */
>> +	if (!pa_data)
>> +		return 0;
>> +
>> +	map = early_memremap(pa_data, sizeof(info));
>> +	memcpy(&info, map, sizeof(info));
>> +	early_memunmap(map, sizeof(info));
>> +
>> +	/* Verify that secrets page address is passed */
> 
> That's hardly verifying something - if anything, it should say
> 
> 	/* smoke-test the secrets page passed */
> 
Noted.

>> +	if (info.secrets_phys && info.secrets_len == PAGE_SIZE)
>> +		return info.secrets_phys;
> 
> ... which begs the question: how do we verify the HV is not passing some
> garbage instead of an actual secrets page?
> 

Unfortunately, the secrets page does not contain a magic header or uuid 
which a guest can read to verify that the page is actually populated by 
the PSP. But since the page is encrypted before the launch so this page 
is always accessed encrypted. If hypervisor is tricking us then all that 
means is guest OS will get a wrong key and will not be able to 
communicate with the PSP to get the attestation reports etc.


> I guess it is that:
> 
> "SNP_LAUNCH_UPDATE can insert two special pages into the guest’s
> memory: the secrets page and the CPUID page. The secrets page contains
> encryption keys used by the guest to interact with the firmware. Because
> the secrets page is encrypted with the guest’s memory encryption
> key, the hypervisor cannot read the keys. The CPUID page contains
> hypervisor provided CPUID function values that it passes to the guest.
> The firmware validates these values to ensure the hypervisor is not
> providing out-of-range values."
> 
>  From "4.5 Launching a Guest" in the SNP FW ABI spec.
> 
> I think that explanation above is very important wrt to explaining the
> big picture how this all works with those pages injected into the guest
> so I guess somewhere around here a comment should say
> 

I will add more explanation.

> "See section 4.5 Launching a Guest in the SNP FW ABI spec for details
> about those special pages."
> 
> or so.
> 
>> +
>> +	return 0;
>> +}
>> +
>> +static int __init add_snp_guest_request(void)
> 
> If anything, that should be called
> 
> init_snp_platform_device()
> 
> or so.
> 

Noted.

>> +{
>> +	struct snp_secrets_page_layout *layout;
>> +	struct snp_guest_platform_data data;
>> +
>> +	if (!sev_feature_enabled(SEV_SNP))
>> +		return -ENODEV;
>> +
>> +	snp_secrets_phys = find_secrets_paddr();
>> +	if (!snp_secrets_phys)
>> +		return -ENODEV;
>> +
>> +	layout = snp_map_secrets_page();
>> +	if (!layout)
>> +		return -ENODEV;
>> +
>> +	/*
>> +	 * The secrets page contains three VMPCK that can be used for
> 
> What's VMPCK?
> 

VM platform communication key.

>> +	 * communicating with the PSP. We choose the VMPCK0 to encrypt guest
> 
> "We" is?
> 
>> +	 * messages send and receive by the Linux. Provide the key and
> 
> "... by the Linux."?! That sentence needs more love.
> 

I will expand comment a bit more.

>> +	 * id through the platform data to the driver.
>> +	 */
>> +	data.vmpck_id = 0;
>> +	memcpy_fromio(data.vmpck, layout->vmpck0, sizeof(data.vmpck));
>> +
>> +	iounmap(layout);
>> +
>> +	platform_device_add_data(&guest_req_device, &data, sizeof(data));
> 
> Oh look, that function can return an error.
> 

Yes, after seeing Dov comment I am adding more checks and return failure.


>> +
>> +	if (!platform_device_register(&guest_req_device))
>> +		dev_info(&guest_req_device.dev, "secret phys 0x%llx\n", snp_secrets_phys);
> 
> Make that message human-readable - not a debug one.
> 

Sure.

thank

Powered by blists - more mailing lists