linux-kernel - Re: [PATCH] kernel/watchdog: change prototype of watchdog_nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFgQCTtehXTfD2rfPOzBneXPYuFsDmozDL2bUT8b1DY1K5AXeQ@mail.gmail.com>
Date:   Thu, 2 Sep 2021 10:53:56 +0800
From:   Pingfan Liu <kernelfans@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     sparclinux@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Wang Qing <wangqing@...o.com>,
        Santosh Sivaraj <santosh@...six.org>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] kernel/watchdog: change prototype of watchdog_nmi_enable()

Hi Petr,

Thank you for reviewing.

But I am composing a series, which may overstep this patch. So please
drop this patch, and sorry for inconvenience.

Regards,

Pingfan

On Thu, Aug 26, 2021 at 10:36 PM Petr Mladek <pmladek@...e.com> wrote:
>
> On Tue 2021-08-24 11:14:35, Pingfan Liu wrote:
> > The only caller does not handle the return value of
> > watchdog_nmi_enable(). If there is an error, it seems to be reported by
> > arch specific code.
> >
> > Hence changing watchdog_nmi_enable() return value from int to void.
> >
> > Signed-off-by: Pingfan Liu <kernelfans@...il.com>
>
> Looks good to me:
>
> Reviewed-by: Petr Mladek <pmladek@...e.com>
>
> Best Regards,
> Petr