[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1630630180-644591-1-git-send-email-jiasheng@iscas.ac.cn>
Date: Fri, 3 Sep 2021 00:49:40 +0000
From: Jiang Jiasheng <jiasheng@...as.ac.cn>
To: bp@...en8.de, tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
hpa@...or.com
Cc: linux-kernel@...r.kernel.org, Jiang Jiasheng <jiasheng@...as.ac.cn>
Subject: [PATCH 3/3] x86/microcode/amd: Add __list_del_entry_valid() in front of __list_del() in free_cache()
Directly use __list_del() to remove 'p->plist' might be unsafe,
as we can see from the __list_del_entry_valid() of 'lib/list_debug.c'
that p->plist->prev or p->plist->next may be the LIST_POISON,
or p->list is not a valid double list.
In that case, __list_del() will be corruption.
Therefore, we suggest that __list_del_entry_valid()
should be added in front of the __list_del() in free_cache.
Signed-off-by: Jiang Jiasheng <jiasheng@...as.ac.cn>
---
arch/x86/kernel/cpu/microcode/amd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
index 3d4a483..e589cff 100644
--- a/arch/x86/kernel/cpu/microcode/amd.c
+++ b/arch/x86/kernel/cpu/microcode/amd.c
@@ -626,6 +626,8 @@ static void free_cache(void)
struct ucode_patch *p, *tmp;
list_for_each_entry_safe(p, tmp, µcode_cache, plist) {
+ if (!__list_del_entry_valid(&p->plist))
+ continue;
__list_del(p->plist.prev, p->plist.next);
kfree(p->data);
kfree(p);
--
2.7.4
Powered by blists - more mailing lists