linux-kernel - [PATCH] wireless: ath5k: Remove unnecessary label of ath5k_beacon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210903062316.11756-1-dingsenjie@163.com>
Date:   Fri,  3 Sep 2021 14:23:16 +0800
From:   dingsenjie@....com
To:     jirislaby@...nel.org, mickflemm@...il.com, mcgrof@...nel.org,
        kvalo@...eaurora.org, davem@...emloft.net, kuba@...nel.org
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, dingsenjie <dingsenjie@...ong.com>
Subject: [PATCH] wireless: ath5k: Remove unnecessary label of ath5k_beacon_update

From: dingsenjie <dingsenjie@...ong.com>

The label just used as return, so we delete it and
use the return statement instead of the goto statement.

Signed-off-by: dingsenjie <dingsenjie@...ong.com>
---
 drivers/net/wireless/ath/ath5k/base.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 4c6e57f..9739189 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -1896,23 +1896,18 @@ static int ath5k_remove_padding(struct sk_buff *skb)
 	struct ath5k_vif *avf;
 	struct sk_buff *skb;
 
-	if (WARN_ON(!vif)) {
-		ret = -EINVAL;
-		goto out;
-	}
+	if (WARN_ON(!vif))
+		return -EINVAL;
 
 	skb = ieee80211_beacon_get(hw, vif);
 
-	if (!skb) {
-		ret = -ENOMEM;
-		goto out;
-	}
+	if (!skb)
+		return -ENOMEM;
 
 	avf = (void *)vif->drv_priv;
 	ath5k_txbuf_free_skb(ah, avf->bbuf);
 	avf->bbuf->skb = skb;
 	ret = ath5k_beacon_setup(ah, avf->bbuf);
-out:
 	return ret;
 }
 
-- 
1.9.1