linux-kernel - Re: [PATCH v2] KVM: x86: Handle SRCU initialization failure during page track init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c0a8a858a805789b9c71b7e54e316403fc41d5e.camel@kernel.org>
Date:   Fri, 03 Sep 2021 09:59:12 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     tcs.kernel@...il.com, pbonzini@...hat.com, seanjc@...gle.com,
        vkuznets@...hat.com, wanpengli@...cent.com, jmattson@...gle.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Haimin Zhang <tcs_kernel@...cent.com>
Subject: Re: [PATCH v2] KVM: x86: Handle SRCU initialization failure during
 page track init

On Fri, 2021-09-03 at 10:37 +0800, tcs.kernel@...il.com wrote:
> From: Haimin Zhang <tcs_kernel@...cent.com>
> 
> Check the return of init_srcu_struct(), which can fail due to OOM, when
> initializing the page track mechanism.  Lack of checking leads to a NULL
> pointer deref found by a modified syzkaller.
> 
> Signed-off-by: Haimin Zhang <tcs_kernel@...cent.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> Reported-by: TCS Robot <tcs_robot@...cent.com>

I'd drop reported-by. It's not a person (I guess) and the desc
is self-contained already.

Anyway,

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

/Jarkko