linux-kernel - Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93705335a3e6dcdb56de601df566445aa5bcb28e.camel@sipsolutions.net>
Date:   Fri, 03 Sep 2021 10:20:13 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Yang Li <yang.lee@...ux.alibaba.com>, jdike@...toit.com
Cc:     richard@....at, anton.ivanov@...bridgegreys.com,
        linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] um: virt-pci: Fix the application of sizeof to
 pointer

On Fri, 2021-09-03 at 15:51 +0800, Yang Li wrote:
> sizeof() when applied to a pointer typed expression gives the size of
> the pointer.
> 
> Clean up coccicheck warning:
> ./arch/um/drivers/virt-pci.c:192:20-26: ERROR: application of sizeof to
> pointer
> 

> -	memset(data, 0xff, sizeof(data));
> +	memset(data, 0xff, sizeof(*data));

Oops. I guess I only tested on 64-bit where this is the same, and in
fact on 32-bit it also wouldn't matter since you can't even do 64-bit
reads there :)

A Fixes: tag would be nice, but otherwise

Reviewed-by: Johannes Berg <johannes@...solutions.net>

johannes