linux-kernel - Re: [PATCH] mtd: rawnand: tegra: Make use of the helper function devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb7aec944e72f91a9a33d7d37d0cbb44@agner.ch>
Date:   Fri, 03 Sep 2021 10:23:45 +0200
From:   Stefan Agner <stefan@...er.ch>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Lucas Stach <dev@...xeye.de>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-mtd@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: tegra: Make use of the helper function
 devm_platform_ioremap_resource()

On 2021-09-01 09:42, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Acked-by: Stefan Agner <stefan@...er.ch>

> ---
>  drivers/mtd/nand/raw/tegra_nand.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/tegra_nand.c
> b/drivers/mtd/nand/raw/tegra_nand.c
> index fbf67722a049..32431bbe69b8 100644
> --- a/drivers/mtd/nand/raw/tegra_nand.c
> +++ b/drivers/mtd/nand/raw/tegra_nand.c
> @@ -1144,7 +1144,6 @@ static int tegra_nand_probe(struct platform_device *pdev)
>  {
>  	struct reset_control *rst;
>  	struct tegra_nand_controller *ctrl;
> -	struct resource *res;
>  	int err = 0;
>  
>  	ctrl = devm_kzalloc(&pdev->dev, sizeof(*ctrl), GFP_KERNEL);
> @@ -1155,8 +1154,7 @@ static int tegra_nand_probe(struct platform_device *pdev)
>  	nand_controller_init(&ctrl->controller);
>  	ctrl->controller.ops = &tegra_nand_controller_ops;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ctrl->regs = devm_ioremap_resource(&pdev->dev, res);
> +	ctrl->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(ctrl->regs))
>  		return PTR_ERR(ctrl->regs);