linux-kernel - Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com>
Date:   Fri, 3 Sep 2021 11:01:58 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     xen-devel@...ts.xenproject.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        "Rafael J. Wysocki" <rafael@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC
 for storing data

On 03.09.21 10:56, Greg Kroah-Hartman wrote:
> On Fri, Sep 03, 2021 at 10:49:36AM +0200, Juergen Gross wrote:
>> In there is no legacy RTC device, don't try to use it for storing trace
>> data across suspend/resume.
>>
>> Cc: <stable@...r.kernel.org>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
>> ---
>>   drivers/base/power/trace.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c
>> index a97f33d0c59f..b7c80849455c 100644
>> --- a/drivers/base/power/trace.c
>> +++ b/drivers/base/power/trace.c
>> @@ -13,6 +13,7 @@
>>   #include <linux/export.h>
>>   #include <linux/rtc.h>
>>   #include <linux/suspend.h>
>> +#include <linux/init.h>
>>   
>>   #include <linux/mc146818rtc.h>
>>   
>> @@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, unsigned int user)
>>   	const char *file = *(const char **)(tracedata + 2);
>>   	unsigned int user_hash_value, file_hash_value;
>>   
>> +	if (!x86_platform.legacy.rtc)
>> +		return 0;
> 
> Why does the driver core code here care about a platform/arch-specific
> thing at all?  Did you just break all other arches?

This file is only compiled for x86. It depends on CONFIG_PM_TRACE_RTC,
which has a "depends on X86" attribute.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3092 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)