linux-kernel - Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210903091040.2bngsvhem2ftzhaz@gilmour>
Date:   Fri, 3 Sep 2021 11:10:40 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and
 drivers

Hi,

On Wed, Sep 01, 2021 at 12:05:22AM -0500, Samuel Holland wrote:
> When the drivers are built as modules, the file name will become the
> module name. Rename the files so everything matches: the Kconfig symbol,
> the platform driver name (as seen in sysfs), and the module name.
> 
> Signed-off-by: Samuel Holland <samuel@...lland.org>

I'm not a big fan of big renames like this, it makes merging and
backporting patches harder in the long term.

I assume you did this to make the module autoloading work? If so, using
MODULE_ALIAS would be less intrusive

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)