linux-kernel - Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210903092108.62oqmqveze7usrgk@gilmour>
Date:   Fri, 3 Sep 2021 11:21:08 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Jernej Škrabec <jernej.skrabec@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>, Chen-Yu Tsai <wens@...e.org>,
        Clément Bœsch <u@....me>,
        Willy Liu <willy.liu@...ltek.com>,
        Rob Herring <robh+dt@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id

On Wed, Sep 01, 2021 at 05:31:32PM +0200, Jernej Škrabec wrote:
> Dne torek, 31. avgust 2021 ob 22:53:24 CEST je Andrew Lunn napisal(a):
> > > True, but then again, DT is a bit special, since it's not used only by 
> Linux. 
> > > It's shared at least with BSDs and U-Boot, which most likely have 
> independent 
> > > driver implementation. That's why it's good to have DT fixes referencing DT 
> > > related commits. As you said, DT described HW wrong.
> > > 
> > > Looking at past Allwinner related DT commits regarding this issue, we were 
> not 
> > > totally consistent. Most of them reference commit where emac node was 
> > > introduced in DT. But I also found a couple of commits which indeed have 
> fixes 
> > > tag for bbc4d71d6354.
> > 
> > All true, and it is not a big deal if it does go back further. I don't
> > care, we can let the Allwinner Maintainer decide. Ah, that is you :-)
> > 
> > I just want to try to keep it simple for somebody who is contributing
> > their first Linux kernel patch. If it is good enough, i say accept it,
> > and we can do a bit more education on the second contribution.
> 
> Maxime, Chen-Yu, thoughts?
> 
> Since there are both approaches for fixes tag already in, I guess this is also 
> fine.

I agree with you, the fixes should point at the initial Device Tree
issue. Our DT are used by other projects and even if in Linux it wasn't
causing any issue before another commit showed up, it might affect those
projects differently.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)