linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Delete ADC config for unused thermistors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n51s1s6L7G1vxbC8PEZ=FBr9mSch81KUBO6fK_jfO8S_CQ@mail.gmail.com>
Date:   Thu, 2 Sep 2021 17:20:43 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Delete ADC config for
 unused thermistors

Quoting Matthias Kaehlcke (2021-09-02 15:47:44)
> The charger thermistor on Lazor, CoachZ rev1 and Pompom rev1+2 is
> either the wrong part or not stuffed at all, the same is true for
> the skin temperature thermistor on CoachZ rev1. The corresponding
> thermal zones are already disabled for these devices, in addition
> delete the ADC nodes of the thermistors.
>
> For Lazor and CoachZ rev1 also disable the PM6150 ADC thermal
> monitor since there are no other temperatures to monitor.
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>
>  .../arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts | 12 ++++++++++++
>  arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi   | 10 ++++++++++
>  .../arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts |  8 ++++++++
>  .../arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dts |  8 ++++++++
>  4 files changed, 38 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
> index 21b516e0694a..edfcd47e1a00 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
> @@ -23,6 +23,18 @@ &charger_thermal {
>         status = "disabled";
>  };
>
> +&pm6150_adc {
> +       /delete-node/ skin-temp-thermistor@4e;
> +       /delete-node/ charger-thermistor@4f;

Is there any other child node? I only see two, unless I missed
something. In which case the whole node can be disabled?

> +};
> +
> +&pm6150_adc_tm {
> +       status = "disabled";
> +
> +       /delete-node/ charger-thermistor@0;
> +       /delete-node/ skin-temp-thermistor@1;
> +};
> +
>  /*
>   * CoachZ rev1 is stuffed with a 47k NTC as thermistor for skin temperature,
>   * which currently is not supported by the PM6150 ADC driver. Disable the
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
> index 00535aaa43c9..57f7b19f83b0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
> @@ -54,6 +54,16 @@ &panel {
>         compatible = "boe,nv133fhm-n62";
>  };
>
> +&pm6150_adc {
> +       /delete-node/ charger-thermistor@4f;

Same question here.

> +};
> +
> +&pm6150_adc_tm {
> +       status = "disabled";
> +
> +       /delete-node/ charger-thermistor@0;
> +};
> +
>  &trackpad {
>         interrupts = <58 IRQ_TYPE_EDGE_FALLING>;
>  };
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts
> index e122a6b481ff..76a130bad60a 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts
> @@ -26,6 +26,14 @@ &charger_thermal {
>         status = "disabled";
>  };
>
> +&pm6150_adc {
> +       /delete-node/ charger-thermistor@4f;

I see there's a 5v choke so this looks good as still enabled.

> +};
> +
> +&pm6150_adc_tm {
> +       /delete-node/ charger-thermistor@0;
> +};
> +
>  &pp3300_hub {
>         /* pp3300_l7c is used to power the USB hub */
>         /delete-property/regulator-always-on;